-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update? #15
update? #15
Conversation
Added SIGINT handler
Let regular guild members submit images for the rotation
updated to support code
should be good though you should review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey so this is a nice idea but I cannot currently merge this because of the things I mentioned in the code.
I do like the idea of having users submit an image and them being approved! With the changes introduced since the v0.5.1 tag this will be possible by having a discord channel full of approved images and a discord channel full of image requests :)
let guild_id = ctx.guild_id().ok_or(CommandErr::GuildOnly)?; | ||
|
||
// Define the private channel ID where submissions will be sent | ||
let private_channel_id = ChannelId(123456789012345678); // Replace with your private channel ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bot is designed to run in multiple guilds so a hard coded value at this point would not work :<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes forgot about that, I'll work on changing it
// Add the approved image to the rotation (implement your own storage for approved images) | ||
// For simplicity, we'll just log it here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently do not plan on storing the images themselves anywhere and instead just using the images hosted on discord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah
// Spawn a task to handle SIGINT | ||
let shard_manager = client.shard_manager.clone(); | ||
tokio::spawn(async move { | ||
signal::ctrl_c().await.expect("Failed to listen for ctrl_c"); | ||
shard_manager.lock().await.shutdown_all().await; | ||
info!("Received SIGINT, shutting down."); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like and and I want to have it as you can see from #14
If you want, we can talk about what you need from the bot in my support discord: https://discord.gg/MMJFtCtYPP Maybe we can figure stuff out together :) |
Closed because of inactivity. Can be reopened when needed. |
No description provided.